affect the failBlock so it can be return in case of error

[stella-pas-rose]

we applied the suggested correction! :)

nextIntegerBase: aRadix ifFail: aBlock
	"Form an integer with optional sign and following digits from sourceStream."

	| isNeg value |
	failBlock := [ aBlock value ].
	
	isNeg := self peekSignIsMinus.
	value := self nextUnsignedIntegerOrNilBase: aRadix.
	value ifNil: [^aBlock value].
	^isNeg
		ifTrue: [value negated]
		ifFalse: [value]

@Solomanoa

Close #19618

[guillep]

Nice Thanks!!

[guillep]

The doc comments fail with an exception:

Integer class>>#readFrom:ifFail:: Doc comment is not well formed. Content: self readFrom: '\' ifFail: [false] >>> false

Traza de la pila

Error
Integer class>>#readFrom:ifFail:: Doc comment is not well formed. Content: self readFrom: '\' ifFail: [false] >>> false
PharoDocCommentExpression(Object)>>error:
PharoDocCommentExpression>>evaluate
CommentTestCase>>evaluate
CommentTestCase>>testIt
CommentTestCase(TestCase)>>performTest

[Gabriel-Darbord]

The failBlock is meant to be culled with error and position, so it shouldn't be wrapped in a no-args block.

Suggested change

	failBlock := [ ^ aBlock value ].
	failBlock := aBlock.

[Gabriel-Darbord]

Adding a test would be great, so the intended culling behavior is preserved.

[Ducasse]

Hi gabriel

I'm not sure but the changes are not equivalent because the [ ^ aBlock value ] acts as an exception (It was probably the way they coded exception before exception.
So we have to check this aspect.