Add FileCard component and integrate with ChatInput#116
Open
kuynkank wants to merge 1 commit into
Open
Conversation
kuynkank
force-pushed
the
migrate-filecard
branch
from
5181d05 to
3d32252
Compare
pglevy
requested changes
May 28, 2026
| {showRemove && ( | ||
| <button | ||
| onClick={onRemove} | ||
| aria-label="Remove file" |
Owner
There was a problem hiding this comment.
"file": "src/components/Chat/FileCard.tsx",
"line": 69,
"summary": "Generic aria-label 'Remove file' is an accessibility regression from the
previous file-specific label",
"failure_scenario": "User with screen reader has 3 file attachments. Tabbing through
remove buttons reads 'Remove file', 'Remove file', 'Remove file' — no way to distinguish
which file each button removes. Old code used aria-label={`Remove ${file.name}`}."
Migrate FileCard from propeller with sailwind conventions: - File type icons for images, PDFs, code, and generic files - Human-readable file size formatting - Optional remove button for input context - Truncation for long file names - Update ChatInput to use FileCard instead of inline file chips - Add stories for ChatPanel, ChatUserMessage, ChatAssistantMessage with file attachments
kuynkank
force-pushed
the
migrate-filecard
branch
from
3d32252 to
937d6c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #97
ChatUserMessage:
ChatAssistantMessage:
ChatPanel:
