Don't include NOTIFY payload in fingerprints.#353
Open
duckinator wants to merge 1 commit into
Open
Conversation
duckinator
force-pushed
the
fingerprint-notify
branch
2 times, most recently
from
July 14, 2026 17:11
5fb7170 to
a06d7a5
Compare
lfittl
reviewed
Jul 16, 2026
duckinator
force-pushed
the
fingerprint-notify
branch
from
July 22, 2026 22:13
a06d7a5 to
48046fa
Compare
duckinator
marked this pull request as ready for review
July 22, 2026 22:14
seanlinsley
reviewed
Jul 23, 2026
seanlinsley
left a comment
seanlinsley
left a comment
Member
There was a problem hiding this comment.
Could you add tests to confirm the fingerprint stays the same with different payloads?
`_fingerprintNotifyStmt` previously fingerprinted the payload, which meant NOTIFY statements with different payloads produced different fingerprints. Now the payload is ignored, bringing it in line with existing (intentional) behavior for the channel name of focusing on the structure, not data.
duckinator
force-pushed
the
fingerprint-notify
branch
from
July 23, 2026 22:06
48046fa to
07b478d
Compare
Contributor
Author
|
@seanlinsley sorry about that, looks like they got lost when I re-did the PR. added the tests I had originally. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_fingerprintNotifyStmtpreviously fingerprinted the payload, which meant NOTIFY statements with different payloads produced different fingerprints.Now the payload is ignored, bringing it in line with existing (intentional) behavior for the channel name of focusing on the structure, not data.