Skip to content

Add functionality to build Windows shared lib dll#296

Open
mysticmind wants to merge 7 commits into
pganalyze:17-latestfrom
mysticmind:build_shared_windows
Open

Add functionality to build Windows shared lib dll#296
mysticmind wants to merge 7 commits into
pganalyze:17-latestfrom
mysticmind:build_shared_windows

Conversation

@mysticmind

@mysticmind mysticmind commented Jul 31, 2025

Copy link
Copy Markdown
  • Add missing implementation for build_shared target in Makefile.mvcc
  • Windows shared lib dll build requires a module-definition file pg_query.def to export the required functions. Add functionality to create the file dynamically by extracting the info from pg_query.h using a Powershell script. It is wired via create_def target in Makefile.mvcc

PS: I am in the process of building a .NET based lib for libpg_query and wanted cross-platform shared libs of libpg_query targeting *nix, OSX and Windows. Noticed the DLL build for Windows was missing hence this PR.

@mysticmind

Copy link
Copy Markdown
Author

@lfittl Did you get a chance to take a look at this PR?

@lfittl

lfittl commented Aug 5, 2025

Copy link
Copy Markdown
Member

@lfittl Did you get a chance to take a look at this PR?

Not yet! I saw this come in, but had some competing priorities. This is on my list to get to however, thanks for your patience.

@mysticmind

Copy link
Copy Markdown
Author

@lfittl Hey Lukas, just checking to see when you could review and merge this PR. If there is anything bothering you, please let me know, I am happy to fix/address it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants