Fix invalid JSON in step-catalog-en.json (missing comma breaks fmlint)#77
Open
skerkvli wants to merge 1 commit into
Open
Fix invalid JSON in step-catalog-en.json (missing comma breaks fmlint)#77skerkvli wants to merge 1 commit into
skerkvli wants to merge 1 commit into
Conversation
Fix missing comma in Go to Layout catalog entry
agentic-fm
approved these changes
Jul 15, 2026
agentic-fm
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for catching this, @skerkvli — a single missing comma had turned step-catalog-en.json into invalid JSON, and since fmlint json.loads the catalog on every XML lint, the whole linter was throwing JSONDecodeError on main. Nice, precise diagnosis.
Verified end-to-end: the catalog at ref=main failed json.load at line 2958, and your one-character fix is exactly right — the file parses cleanly with it applied. Approving.
Heads-up for transparency: the same fix also just landed on main via our internal publish, so you may see it as already present — but your catch was real and independent, and we're merging your PR so it's properly credited to you. 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Go to Layoutstep'sLayoutparam (added in the GoToLayoutFix change)is missing a comma after its "notes" value, so step-catalog-en.json is not
valid JSON.
Because fmlint loads this catalog on every XML lint (catalog.has_step ->
json.load), the whole linter fails with:
Fix: add the missing comma after the "notes" line. Verified the file parses
and
python3 -m agent.fmlintruns again afterward.