Skip to content

Fix invalid JSON in step-catalog-en.json (missing comma breaks fmlint)#77

Open
skerkvli wants to merge 1 commit into
petrowsky:mainfrom
skerkvli:patch-1
Open

Fix invalid JSON in step-catalog-en.json (missing comma breaks fmlint)#77
skerkvli wants to merge 1 commit into
petrowsky:mainfrom
skerkvli:patch-1

Conversation

@skerkvli

@skerkvli skerkvli commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

The Go to Layout step's Layout param (added in the GoToLayoutFix change)
is missing a comma after its "notes" value, so step-catalog-en.json is not
valid JSON.

Because fmlint loads this catalog on every XML lint (catalog.has_step ->
json.load), the whole linter fails with:

json.decoder.JSONDecodeError: Expecting ',' delimiter (line ~2958)

Fix: add the missing comma after the "notes" line. Verified the file parses
and python3 -m agent.fmlint runs again afterward.

Fix missing comma in Go to Layout catalog entry

@agentic-fm agentic-fm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this, @skerkvli — a single missing comma had turned step-catalog-en.json into invalid JSON, and since fmlint json.loads the catalog on every XML lint, the whole linter was throwing JSONDecodeError on main. Nice, precise diagnosis.

Verified end-to-end: the catalog at ref=main failed json.load at line 2958, and your one-character fix is exactly right — the file parses cleanly with it applied. Approving.

Heads-up for transparency: the same fix also just landed on main via our internal publish, so you may see it as already present — but your catch was real and independent, and we're merging your PR so it's properly credited to you. 🙏

@agentic-fm agentic-fm added the reviewed Reviewed and approved; awaiting merge label Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewed Reviewed and approved; awaiting merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants