build: add GitHub workflow for Windows exe and MSI#7
Open
peterzen wants to merge 13 commits into
Open
Conversation
client/webserver: fix malformed version string parsing
client/core: add dex.decred.online to mainnet known-server list
The tooCheap bump action recomputed replacement fees from current network conditions only, never consulting the transaction being replaced. When the provider's tip-cap suggestion is cached (1 hour TTL), the replacement could carry the exact tip the original was created with, guaranteeing rejection by geth-family mempools, which require both the fee cap and tip cap to be strictly greater than, and at least 10% above, the old values. Raise both components to at least their replace-by-fee floors relative to the transaction being replaced. Co-Authored-By: Claude Fable 5 <[email protected]>
The server-assigned swap fee rate becomes the transaction's gas fee cap verbatim. If the network's base fee exceeds it at broadcast time, the tx cannot be mined until the base fee recedes, and meanwhile occupies the nonce, blocking every subsequent transaction from the wallet until it is mined or replaced. Check the assigned rate against the current base fee before initiation and error instead of broadcasting, leaving the nonce unspent. Core retries the swap, which proceeds if the base fee recedes within the broadcast timeout. The already-initiated recovery path is unaffected. Redeem already handles this condition by raising its fee cap, funds permitting. Co-Authored-By: Claude Fable 5 <[email protected]>
Adds a Build Windows workflow that builds bisonw-desktop.exe and the MSI installer on a Windows runner, and cross-compiles the exe via the existing Docker path on Linux. Adds a --no-sign flag to pkg-windows.cmd for CI use and fails the script when the MSI build errors. Co-Authored-By: Claude Fable 5 <[email protected]>
WiX writes the MSI into a culture subdirectory (en-US), so the upload glob must be recursive. Fail the upload steps when no files are found. Run the native Windows job only on workflow_dispatch; pull requests run the cheaper Docker cross-compile job. Co-Authored-By: Claude Fable 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Build Windows workflow that builds
bisonw-desktop.exeand the MSI installer natively on a Windows runner, and cross-compiles the exe via the existing Docker path on Linux. Adds a--no-signflag topkg-windows.cmdfor CI use.