ci: Add macOS binary and DMG build workflow#14
Open
peterzen wants to merge 2 commits into
Open
Conversation
Adds build-macos.yml (workflow_dispatch + PR path trigger) that builds the standalone bisonw binary and the Electron bisonw-desktop DMG for both darwin/amd64 and darwin/arm64, and verifies the arm64 artifacts are Apple Silicon compatible (architecture + ad-hoc signature). Also fixes electron/pkg.sh: npm was consuming the --platform/--arch flags itself, so electron-forge packaged the host architecture for every target; pass them through with -- and map amd64 to Electron's x64 name.
The first run confirmed the toolchain produces correct arm64 (Apple Silicon) artifacts; no need to re-verify on every build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
workflow_dispatch-triggerable GitHub workflow that builds the standalonebisonwbinary and the Electronbisonw-desktopDMG for macOS on both Intel (amd64) and Apple Silicon (arm64).Also fixes an arch-selection bug in
electron/pkg.shthat caused both DMGs to be packaged for the build host's architecture.