PS [DOCS] - audit log filter updates 8.4#702
Conversation
b8c8d84 to
0236849
Compare
0236849 to
54e525f
Compare
54e525f to
068ebde
Compare
068ebde to
b1e70ea
Compare
b1e70ea to
3254689
Compare
3254689 to
9678207
Compare
9678207 to
d3ddba4
Compare
d3ddba4 to
d3a4631
Compare
d3a4631 to
9f239ec
Compare
9f239ec to
9fc9bc8
Compare
9fc9bc8 to
c06bf55
Compare
0789e5a to
0f97c19
Compare
0f97c19 to
d9d2114
Compare
d9d2114 to
3e2e09d
Compare
3e2e09d to
71af4d2
Compare
71af4d2 to
aeec87e
Compare
aeec87e to
30983cc
Compare
30983cc to
178300d
Compare
178300d to
4695d7b
Compare
4695d7b to
dde0c7b
Compare
dde0c7b to
9371742
Compare
9371742 to
a3ee50a
Compare
a3ee50a to
6e072df
Compare
inikep
left a comment
There was a problem hiding this comment.
Reviewed the audit_log_filter doc updates against the component source at components/audit_log_filter/ (PS 8.4). The bulk of the changes — system variables, UDFs, filter-definition JSON, formats, encryption/compression, file naming, and migration — verify correctly against the source.
Four factual errors need fixing (inline):
install-audit-log-filter.md—INSTALL COMPONENT 'file://audit_log_filter'is missing thecomponent_prefix; as written it fails to load.block-statements-with-audit-filter.md— "Blocked statements are still logged" is backwards; blocked events go to the server error log, not the audit log.block-statements-with-audit-filter.md— the "Not every event is abortable" section describes a "Can be Aborted" column and an abortability gate that don't exist in the docs or the component.audit-log-filter-old.md— the OLD "Optional attributes" table lists five NEW-format-only elements (MYSQL_VERSION,OS_VERSION,STARTUP_OPTIONS,STATUS_CODE,VERSION).
Details and source citations are in the line comments.
| # Audit Log Filter overview | ||
|
|
||
| The Audit Log Filter component allows you to monitor, log, and block a connection or query actively executed on the selected server. | ||
| The Audit Log Filter component records, audits, and can block matching connections or statements on the server you configure. |
There was a problem hiding this comment.
I don't like wording from upstream. We don't block anything. We just skip (don't log) events:
▎ The Audit Log Filter component audits activity on the server you configure by recording events to a
▎ log. Filtering rules control which events are recorded — matching connections and statements are
▎ either logged or excluded.
inikep
left a comment
There was a problem hiding this comment.
Follow-up on the redact-audit-log-fields.md page: one factual correction on the count of replaceable fields (inline). The rest of the page verifies correctly against the component source.
docs/audit-log-filter-formats.md
docs/audit-log-filter-json.md
docs/audit-log-filter-naming.md
docs/audit-log-filter-new.md
docs/audit-log-filter-overview.md
docs/audit-log-filter-restrictions.md
docs/audit-log-filter-security.md
docs/audit-log-filter-variables.md
docs/filter-audit-log-filter-files.md
docs/index-contents.md
docs/index.md
docs/manage-audit-log-filter.md
docs/reading-audit-log-filter-files.md
docs/write-filter-definitions.md
mkdocs-base.yml