PMM-7 pull upstream changes by BupycHuk · Pull Request #171 · percona/postgres_exporter

BupycHuk · 2023-11-15T13:58:35Z

No description provided.

Signed-off-by: Eric tyrrell <[email protected]>

Signed-off-by: Joe Adams <[email protected]>

Another case of untyped integer overflows on 32-bit arch. Signed-off-by: Daniel Swarbrick <[email protected]>

Run Go tests with 32-bit to validate value overflow. Signed-off-by: SuperQ <[email protected]>

* Bump github.com/prometheus/client_golang from 1.16.0 to 1.17.0 Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.16.0 to 1.17.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.16.0...v1.17.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Update tests for latest client_golang. Signed-off-by: SuperQ <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: SuperQ <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: SuperQ <[email protected]>

Signed-off-by: prombot <[email protected]>

Fixes #921 Signed-off-by: Joe Adams <[email protected]>

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.10.0 to 0.17.0. - [Commits](golang/net@v0.10.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [ENHANCEMENT] Add 1kB and 2kB units #915 * [BUGFIX] Add error log when probe collector creation fails #918 * [BUGFIX] Fix test build failures on 32-bit arch #919 * [BUGFIX] Adjust collector to use separate connection per scrape #936 Signed-off-by: SuperQ <[email protected]>

Signed-off-by: prombot <[email protected]>

it-percona-cla · 2023-11-15T13:58:40Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 8 committers have signed the CLA.

❌ sysadmind
❌ avances123
❌ pierresouchay
❌ cristiangreco
❌ dannotripp
❌ Nudin
❌ prombot
❌ eugercek
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Signed-off-by: prombot <[email protected]>

Signed-off-by: Alex Simenduev <[email protected]>

Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.44.0 to 0.45.0. - [Release notes](https://github.com/prometheus/common/releases) - [Commits](prometheus/common@v0.44.0...v0.45.0) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [github.com/prometheus/client_model](https://github.com/prometheus/client_model) from 0.4.1-0.20230718164431-9a2bf3000d16 to 0.5.0. - [Release notes](https://github.com/prometheus/client_model/releases) - [Commits](https://github.com/prometheus/client_model/commits/v0.5.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_model dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat(pg_stat_database): active time metric --------- Signed-off-by: Jiri Sveceny <[email protected]>

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.17.0. - [Commits](golang/crypto@v0.14.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.17.0 to 1.18.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.17.0...v1.18.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

This is the only log message which didn't specify a level in the postgres_exporter. I am unsure if this log message should be info or debug, but leaning towards the more important since previously it would just always log. The way I validated this was the only non-leveled logger was via grep. Both of these only returned this callsite previously: git grep 'logger\.Log' git grep '\.Log(' | grep -v level Signed-off-by: Keegan Carruthers-Smith <[email protected]>

* Add database connection limits metrics Signed-off-by: Jocelyn Thode <[email protected]> * Add roles connection limits metrics Signed-off-by: Jocelyn Thode <[email protected]> * Fix copyright year Co-authored-by: Joe Adams <[email protected]> Signed-off-by: Jocelyn Thode <[email protected]> * Fix spacing in pgDatabaseQuery Co-authored-by: Joe Adams <[email protected]> Signed-off-by: Jocelyn Thode <[email protected]> * Fix case on pgRolesConnectionLimitsQuery Co-authored-by: Joe Adams <[email protected]> Signed-off-by: Jocelyn Thode <[email protected]> * Do not add roleMetrics when row is not valid Signed-off-by: Jocelyn Thode <[email protected]> --------- Signed-off-by: Jocelyn Thode <[email protected]> Signed-off-by: Jocelyn Thode <[email protected]> Co-authored-by: Joe Adams <[email protected]>

Bumps [github.com/DATA-DOG/go-sqlmock](https://github.com/DATA-DOG/go-sqlmock) from 1.5.0 to 1.5.2. - [Release notes](https://github.com/DATA-DOG/go-sqlmock/releases) - [Commits](DATA-DOG/go-sqlmock@v1.5.0...v1.5.2) --- updated-dependencies: - dependency-name: github.com/DATA-DOG/go-sqlmock dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.18.0 to 1.19.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/v1.19.0/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.18.0...v1.19.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [github.com/prometheus/client_model](https://github.com/prometheus/client_model) from 0.5.0 to 0.6.0. - [Release notes](https://github.com/prometheus/client_model/releases) - [Commits](prometheus/client_model@v0.5.0...v0.6.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_model dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps google.golang.org/protobuf from 1.32.0 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [github.com/prometheus/exporter-toolkit](https://github.com/prometheus/exporter-toolkit) from 0.10.0 to 0.11.0. - [Release notes](https://github.com/prometheus/exporter-toolkit/releases) - [Changelog](https://github.com/prometheus/exporter-toolkit/blob/master/CHANGELOG.md) - [Commits](prometheus/exporter-toolkit@v0.10.0...v0.11.0) --- updated-dependencies: - dependency-name: github.com/prometheus/exporter-toolkit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.20.0 to 0.23.0. - [Commits](golang/net@v0.20.0...v0.23.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: Add safe_wal_size to replication_slot Signed-off-by: MarcWort <[email protected]> * feat: Add wal_status to replication_slot Signed-off-by: MarcWort <[email protected]> --------- Signed-off-by: MarcWort <[email protected]>

Signed-off-by: MarcWort <[email protected]>

Better example for the quick start with prometheus config and avoiding deprecated env variables. Signed-off-by: fhackenberger <[email protected]>

Signed-off-by: Steffen Zieger <[email protected]>

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.43.0 to 0.45.0. - [Commits](golang/crypto@v0.43.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update GitHub Actions config to run tests Signed-off-by: Joe Adams <[email protected]> * Add CI steps for release and include all postgres versions Signed-off-by: Joe Adams <[email protected]> * Disable circleci jobs This will stop the CI jobs but leave existing PRs in place until we can get those updated. Signed-off-by: Joe Adams <[email protected]> --------- Signed-off-by: Joe Adams <[email protected]>

When there are no long running transactions, the oldest timestamp will be NULL. This sets the metrics value to 0 (age). Also adds a test for this behavior. Fixes #1223 Signed-off-by: Joe Adams <[email protected]>

Signed-off-by: prombot <[email protected]> Co-authored-by: Cristian Greco <[email protected]>

Add documentation for stat_checkpointer collector Signed-off-by: Fabio Rueda <[email protected]>

Signed-off-by: prombot <[email protected]>

…austing PG connections (#1229) * Ensure collection returns within a specified delay **Context**: As explained in #1228, when database is very slow to answer, every call to prometheus exporter might consume a new connection and possibly consume all available connections **Solution**: Ensure a Context with a specified Timeout is specified, so the connection will end if duration of collection is too long Signed-off-by: Pierre Souchay <[email protected]> * test: added TestPGDatabaseTimeout to ensure our timing behaves as it should Signed-off-by: Pierre Souchay <[email protected]> * document the new variable `PG_EXPORTER_COLLECTION_TIMEOUT` in the README.md Signed-off-by: Pierre SOUCHAY <[email protected]> * CollectionTimeout -> WithCollectionTimeout Signed-off-by: Pierre SOUCHAY <[email protected]> * Document and report 0 value for PG_EXPORTER_COLLECTION_TIMEOUT Signed-off-by: Pierre SOUCHAY <[email protected]> * move test to the right place Signed-off-by: Pierre SOUCHAY <[email protected]> * ensure that UTest do not take too much time Signed-off-by: Pierre SOUCHAY <[email protected]> --------- Signed-off-by: Pierre Souchay <[email protected]> Signed-off-by: Pierre SOUCHAY <[email protected]> Co-authored-by: Pierre SOUCHAY <[email protected]>

Signed-off-by: prombot <[email protected]>

…1232) * feat: allow excluding databases or users names in `stat_statements` Add a couple of of options to the `stat_statements` collector that allow excluding certain database names or user names from metrics. This is useful if you don't care about certain preconfigured databases with admin activity. Signed-off-by: Cristian Greco <[email protected]> * address review feedback Signed-off-by: Cristian Greco <[email protected]> --------- Signed-off-by: Cristian Greco <[email protected]>

Signed-off-by: Cristian Greco <[email protected]>

Signed-off-by: prombot <[email protected]>

* feat: reorganize code to remove the main package Move all `main` code to `exporter`, for easier code embedding. Signed-off-by: Cristian Greco <[email protected]> * move logger args to NewExporter signature Signed-off-by: Cristian Greco <[email protected]> --------- Signed-off-by: Cristian Greco <[email protected]>

Signed-off-by: prombot <[email protected]>

* fix: Do not crash on bad pg_settings value pg_settings metrics would panic when the parsing fails. This is a poor experience for users. An exporter should not panic. This skips unparsable metrics and instead logs a warning. Fixes: #1240 --------- Signed-off-by: Joe Adams <[email protected]>

Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.67.4 to 0.67.5. - [Release notes](https://github.com/prometheus/common/releases) - [Changelog](https://github.com/prometheus/common/blob/main/CHANGELOG.md) - [Commits](prometheus/common@v0.67.4...v0.67.5) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-version: 0.67.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

) Bumps [github.com/prometheus/exporter-toolkit](https://github.com/prometheus/exporter-toolkit) from 0.15.0 to 0.15.1. - [Release notes](https://github.com/prometheus/exporter-toolkit/releases) - [Commits](prometheus/exporter-toolkit@v0.15.0...v0.15.1) --- updated-dependencies: - dependency-name: github.com/prometheus/exporter-toolkit dependency-version: 0.15.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Cristian Greco <[email protected]>

Signed-off-by: prombot <[email protected]>

* fix: ignore setting `google_dataplex.max_messages` Followup of #1252 Ignore this setting altogether, as logging a warn at each scrape for a cloud provider specific entry seems a waste of resources. Signed-off-by: Cristian Greco <[email protected]> * add comment Signed-off-by: Cristian Greco <[email protected]> --------- Signed-off-by: Cristian Greco <[email protected]>

* Fix wal collector NULL SUM(size) * Use sql.NullInt64 for WAL size, skip metric when NULL Ref: #1264 --------- Signed-off-by: Danno Tripp <[email protected]>

* Filter and warn about duplicates in pg_stat_statements Signed-off-by: Michael Schönitzer <[email protected]> Signed-off-by: Michael F. Schönitzer <[email protected]> * Structured log message Co-authored-by: Cristian Greco <[email protected]> Signed-off-by: Michael F. Schönitzer <[email protected]> * Use struct instead of string for map of seen objects Signed-off-by: Michael F. Schönitzer <[email protected]> * Switch to a map(string)struct{} data structure Signed-off-by: Michael F. Schönitzer <[email protected]> --------- Signed-off-by: Michael Schönitzer <[email protected]> Signed-off-by: Michael F. Schönitzer <[email protected]> Co-authored-by: Cristian Greco <[email protected]>

Signed-off-by: Emin Umut Gercek <[email protected]>

Signed-off-by: prombot <[email protected]> Co-authored-by: Cristian Greco <[email protected]>

Signed-off-by: Cristian Greco <[email protected]>

Signed-off-by: prombot <[email protected]>

Eric-Tyrrell22 and others added 10 commits September 19, 2023 21:40

Adds 1kB and 2kB units (#915)

e3eaa91

Signed-off-by: Eric tyrrell <[email protected]>

Add error log when probe collector creation fails (#918)

30d7d25

Signed-off-by: Joe Adams <[email protected]>

Fix test build failures on 32-bit arch again (#919)

51415a0

Another case of untyped integer overflows on 32-bit arch. Signed-off-by: Daniel Swarbrick <[email protected]>

Add 32-bit testing to CI (#920)

5e24d43

Run Go tests with 32-bit to validate value overflow. Signed-off-by: SuperQ <[email protected]>

Update common Prometheus files (#926)

f0f051c

Signed-off-by: prombot <[email protected]>

Adjust collector to use separate connection per scrape (#931)

2a5692c

Fixes #921 Signed-off-by: Joe Adams <[email protected]>

Update common Prometheus files (#951)

94b0651

Signed-off-by: prombot <[email protected]>

prombot and others added 19 commits November 23, 2023 09:42

Update common Prometheus files (#963)

f0ea016

Signed-off-by: prombot <[email protected]>

pg_replication_slot: add slot type label (#960)

ae1375b

Signed-off-by: Alex Simenduev <[email protected]>

pg_stat_database: added support for active_time counter (#961)

f5b613a

* feat(pg_stat_database): active time metric --------- Signed-off-by: Jiri Sveceny <[email protected]>

fix: Only query active_time on pg>=14 (#1045)

49f66e1

Signed-off-by: MarcWort <[email protected]>

Update README.md (#1038)

3c5ef40

Better example for the quick start with prometheus config and avoiding deprecated env variables. Signed-off-by: fhackenberger <[email protected]>

stop logging errors on replicas, fixes #547 (#1048)

98f75c7

Signed-off-by: Steffen Zieger <[email protected]>

dependabot Bot and others added 29 commits December 10, 2025 09:06

Fix NULL on long_running_transactions collector (#1230)

7786601

When there are no long running transactions, the oldest timestamp will be NULL. This sets the metrics value to 0 (age). Also adds a test for this behavior. Fixes #1223 Signed-off-by: Joe Adams <[email protected]>

Update common Prometheus files (#1222)

f2203ba

Signed-off-by: prombot <[email protected]> Co-authored-by: Cristian Greco <[email protected]>

Document stat_checkpointer collector option (#1226)

97fb871

Add documentation for stat_checkpointer collector Signed-off-by: Fabio Rueda <[email protected]>

Update common Prometheus files (#1233)

5724e0c

Signed-off-by: prombot <[email protected]>

Update common Prometheus files (#1234)

30e8ab3

Signed-off-by: prombot <[email protected]>

Update common Prometheus files (#1236)

c7a09a2

Signed-off-by: prombot <[email protected]>

Update common Prometheus files (#1237)

c285030

Signed-off-by: prombot <[email protected]>

ci: add postgres 18.1 to test matrix (#1239)

de76d83

Signed-off-by: Cristian Greco <[email protected]>

Update common Prometheus files (#1243)

9599702

Signed-off-by: prombot <[email protected]>

Update common Prometheus files (#1244)

47d0100

Signed-off-by: prombot <[email protected]>

Update common Prometheus files (#1251)

e27c227

Signed-off-by: prombot <[email protected]>

Prepare release 0.19.0 (#1256)

a433d58

Signed-off-by: Cristian Greco <[email protected]>

Update common Prometheus files (#1260)

a00749f

Signed-off-by: prombot <[email protected]>

wal: Fix collector NULL SUM(size) (#1265)

ee441c1

* Fix wal collector NULL SUM(size) * Use sql.NullInt64 for WAL size, skip metric when NULL Ref: #1264 --------- Signed-off-by: Danno Tripp <[email protected]>

Optimize pg_stat_statements queries (#1267)

4a776be

Signed-off-by: Emin Umut Gercek <[email protected]>

Update common Prometheus files (#1266)

e9aa46c

Signed-off-by: prombot <[email protected]> Co-authored-by: Cristian Greco <[email protected]>

Prepare release v0.19.1 (#1268)

333363a

Signed-off-by: Cristian Greco <[email protected]>

Update common Prometheus files (#1269)

4f6941f

Signed-off-by: prombot <[email protected]>

Update common Prometheus files (#1272)

f0117d7

Signed-off-by: prombot <[email protected]>

ademidoff closed this Mar 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PMM-7 pull upstream changes#171

PMM-7 pull upstream changes#171
BupycHuk wants to merge 132 commits into
percona:mainfrom
prometheus-community:master

BupycHuk commented Nov 15, 2023

Uh oh!

it-percona-cla commented Nov 15, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

BupycHuk commented Nov 15, 2023

Uh oh!

it-percona-cla commented Nov 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

it-percona-cla commented Nov 15, 2023 •

edited

Loading