MIDI note parameter support - #258
Merged
Merged
Conversation
This was referenced Jun 26, 2026
Collaborator
Author
|
I'm moving ahead with this. Steps before merge:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #128, I'd like to extend this dataset to document MIDI note behaviour, which is especially helpful with drum machines.
I propose doing this by accepting
device.triggers.csvfiles that use a different format than the existing dataset'sdevice.csvfiles. I think this serves people who only want to read one kind of file, and people who want simple access to both kinds of files, equally well.Here are some samples:
These are the proposed columns:
manufacturerdevice.triggers.csvsectionsound_namesound_descriptionsound_nameis not self-explanatory. Caveats and warnings belong in thecommentscolumn.midi_channelbasic,omni,active.note_number_min_valuenote_number_max_valuenote_number_default_valuecommentssound_description.velocity_usage1~127: Volume)The valid special values in the
midi_channelcolumn mean:basic: The device's MIDI channel, when it only has an undocumented and single (either configurable or factory-set) channel.omni: The device receives on all MIDI channels, and doesn't distinguish between them.auto: Some multi-track/multi-instrument devices have a MIDI channel that routes to the currently-active track/instrument (Elektron, etc.); this value indicates the active routing channel should be used.Some columns I didn't include:
C#2, etc): I considered having two columns for this information (for the corresponding Yamaha and Roland pitch), but I feel that this places a burden on the documenter that's disproportionate to the value of recording this easily-computable information. The project website might compute and display this information for the convenience of visitors.I'd be happy to hear any feedback on this approach.