Fix OpenGL renderer crash on GPUs without GL_EXT_unpack_subimage#79
Merged
Conversation
The native createTexture uses GL_UNPACK_ROW_LENGTH_EXT which requires the GL_EXT_unpack_subimage extension. On GPUs that don't support it (e.g. Mali-470), glPixelStorei produces a GL error that gets picked up by subsequent checkGlError calls, crashing the render thread. Fix: detect extension support in onSurfaceCreated and fallback to BITMAP_ALPHA mode (upload via GlUtil.createTexture(bitmap)) when the extension is unavailable. Also add ignore=dirty to libass-cmake submodule to suppress untracked build artifacts (fontconfig m4 files) from polluting git status. Fixes: #78
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native createTexture uses GL_UNPACK_ROW_LENGTH_EXT which requires the GL_EXT_unpack_subimage extension. On GPUs that don't support it (e.g. Mali-470), glPixelStorei produces a GL error that gets picked up by subsequent checkGlError calls, crashing the render thread.
Fix: detect extension support in onSurfaceCreated and fallback to BITMAP_ALPHA mode (upload via GlUtil.createTexture(bitmap)) when the extension is unavailable.
Also add ignore=dirty to libass-cmake submodule to suppress untracked build artifacts (fontconfig m4 files) from polluting git status.
Fixes: #78