Bug fixed conductivity#331
Open
shaering wants to merge 26 commits into
Open
Conversation
…and calcs in flow which is exported to thermo-chem, moved supg-like section to utils, changed interface for streamwiseDiffusion routines to take the gradients directly. Commented out communications portions of curl calcs as they seem to be introducing partition imprinting. Fixed small bug in channel temp ic
…later) and added test case
…essary and conflicts with new interface
…nlet bc for loMach. Various other small changes
…not N, trying to track problem
…rly implemented along with zero input power leading to unwanted joule heating
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to merge in fixes to joule heating when sigma is zero. This is on top of a dirty branch with a slew of small changes over time.