chore(types): add FE types for GET /notifications/admin/recent#2445
Open
innolope-dev wants to merge 1 commit into
Open
chore(types): add FE types for GET /notifications/admin/recent#2445innolope-dev wants to merge 1 commit into
innolope-dev wants to merge 1 commit into
Conversation
Sync the OpenAPI snapshot + regenerated TS types with the new admin diagnostics endpoint added in peanut-api-ts (surface failed notification sends). Additive only — no existing paths change.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded an OpenAPI definition for ChangesAdmin notification API
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Code-analysis diffPainscore total: 6207.05 → 6207.19 (+0.14) 🆕 New findings (355)
…and 335 more. ✅ Resolved (353)
…and 333 more. |
Contributor
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Regenerates the committed OpenAPI snapshot (
src/types/api.openapi.json) and TypeScript types (src/types/api.generated.ts) to include the new backend endpointGET /notifications/admin/recent, added in peanut-api-ts#1197.Notes
.prettierignored (snapshot is pulled verbatim from the BE spec), so the block is spliced in the BE's tab format rather than reformatted.pnpm gen:apioutput is idempotent, socheck:apipasses.x-admin-token), so the FE won't call it — this keeps the generated types a faithful mirror of the backend contract, nothing more.Depends on peanut-api-ts#1197 landing (the endpoint must exist on the BE for the types to be meaningful).
Summary by CodeRabbit