fix(card): match in-app card art to finalised Visa Platinum lockup#2444
fix(card): match in-app card art to finalised Visa Platinum lockup#2444kushagrasarathe wants to merge 3 commits into
Conversation
The in-app card is composited layer-by-layer in code, so it drifted from the finalised Rain art (what Apple Wallet shows): it rendered a mascot with no PEANUT wordmark and an inverted-white Visa with no tier. Swap the top row to the PEANUT lockup (mascot + black wordmark) and a black VISA with a Platinum tier line. Closes TASK-20469.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthrough
ChangesCard Face Updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code-analysis diffPainscore total: 6207.44 → 6207.84 (+0.4) 🆕 New findings (4)
✅ Resolved (3)
|
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
The composited hand used -rotate-15 + h-full + a negative top inset, which shoved it up so the fingertips crowded the Visa and the gesture tilted off from the finalised Rain art. Anchor it upright at the bottom (h-90%) so the fingertips clear the top logos and the arm sweeps to the bottom-right corner.
Two corrections after seeing the real card: - The PEANUT wordmark was rendering white (PEANUT_LOGO is the dark-bg variant). Use PEANUTMAN + PEANUT_LOGO_BLACK for the black lockup the finalised art shows. - The bottom-anchored hand covered the eye toggle and the revealed PAN/CVV. Slide it diagonally off the bottom-right corner while details are shown or being fetched (loading skeletons included), and move the masked/error eye inline with the number so it stays in a hand-free zone. The hand slides back when the card is re-masked.
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
The in-app card (
CardFace.tsx) is composited layer-by-layer in code, so it drifted from the finalised Rain card art (what Apple Wallet shows). This brings it back in line and fixes the interaction problems that surfaced once the art matched:PEANUTMAN+PEANUT_LOGO_BLACK).PEANUT_LOGOis the white-on-dark variant, so it must not be used on the pink card.pointer-events-none, so it never intercepts the eye tap.Closes TASK-20469.
Risk
Low. Presentational-only, one file, in-repo assets. No logic/API/cross-repo impact. Reveal/mask/loading/error states all covered;
locked(unused) left as-is.Design notes
PixelatedCardFace.tsx(share/tease) carries the same logo drift but is intentionally pixelated + rides the html-to-image pipeline — separate follow-up.QA
Verified locally against the real component (dev preview driving
CardFace): masked → loading (skeletons, hand slid away) → revealed (all fields + hide button legible) → re-mask (hand slides back). Typecheck clean; 3 CardFace unit tests pass.Summary by CodeRabbit