ci(release): honor codegen_cs_version override only on dry runs#37
Merged
Conversation
The resolve job documented codegen_cs_version as dry_run-only but applied any override unconditionally. Force CGV back to VERSION on non-dry runs so a live release can never pick up a stale codegen-cs image override.
Contributor
Scala coverage
|
Contributor
C# coverage
|
Contributor
C# build matrix
|
Contributor
Scala build matrix
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-open
Skipped the multi-agent pre-open fan-out: the diff is a single conditional shell line in one CI workflow. Verified manually instead —
actionlint .github/workflows/release.yamlis clean (exit 0, no findings) and both logic branches were walked through (see Testing).Summary
Hardens the
resolvejob in the tag-triggered release orchestrator (added in #36). Thecodegen_cs_versioninput is documented as dry-run-only, but the previously-flagged behavior applied any override unconditionally. This forces the resolved codegen-cs version back to the releaseVERSIONon every non-dry run, so a live release can never pick up a stale or wrong codegen-cs image override. Harmless on the real tag-push path today (no override is passed there); this is defense-in-depth.Changes
.github/workflows/release.yaml,resolvejob: afterCGVis resolved from the input, add[ "$DRY" = "true" ] || CGV="${VERSION}"so a non-dry run always usesVERSIONregardless of anycodegen_cs_versionoverride.Testing
actionlint .github/workflows/release.yaml→ exit 0, no findings. Repo-wideactionlintreports only the pre-existing SC2129 style warning in the untouchedbuild-oci-codegen-cs.yaml(not introduced here).dry_run=true→[ "$DRY" = "true" ]is true, the||short-circuits,CGVkeeps the input override (or itsVERSIONfallback when no override was passed).dry_run=false→[ "$DRY" = "true" ]is false, soCGVis reassigned to${VERSION}even when an override was supplied.