Update bitcoind async client 0.14#1646
Conversation
Coverage Report for CI Build 27632118494Coverage remained the same at 85.229%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
DanGould
left a comment
There was a problem hiding this comment.
LGTM
On a related note, now that bitreq is pulled into payjoin-cli it seems the time has come to revisit bitreq and get that across the line, for the ~payjoin-cli-1.1 milestone by reviewing this PR and seeing a release through rust-bitcoin/corepc#516
|
@caarloshenriq what pushes bitreq up to 0.3.7. 0.14 seems to be on 0.3.5 https://github.com/alpenlabs/bitcoind-async-client/blob/v0.14.0/Cargo.toml#L30 |
|
Looks like I think #1640 will prevent this from drifting past the lowest necessary. |
The previous constraint (>=0.10.8, <0.10.10) was a workaround for a breaking change accidentally backported into 0.10.10 upstream. Move to 0.14.0, which includes that change intentionally and is API-compatible with 0.10.10 going forward. This requires: - Passing `None` for the new `options: Option<BroadcastOptions>` parameter of `send_raw_transaction`, added in the 0.10.10/0.14.0 API change. - Raising the minimum versions of tokio-rustls (0.26.2 -> 0.26.4) and rustls (0.23.31 -> 0.23.38) in payjoin, payjoin-mailroom, and payjoin-test-utils, since bitreq (a transitive dependency of bitcoind-async-client 0.14.0) requires these minimums and direct-minimal-versions resolution fails otherwise.
5d34ad8 to
36462c9
Compare
bitcoind-async-client 0.14.0 declares bitreq = "0.3.5", but since bitreq isn't a direct workspace dependency (it's transitive, pulled in only via bitcoind-async-client), direct-minimal-versions doesn't pin it to that literal minimum. The resolver picks the latest semver-compatible version available, which is 0.3.7 in both lockfiles. I checked 0.3.5, 0.3.6, and 0.3.7: all three declare identical rustls 0.23.38 / tokio-rustls 0.26.4 minimums, so the TLS version bumps in this PR are unrelated to which patch of bitreq gets resolved. Happy to pin it down to 0.3.5 if you'd prefer. |
|
Go ahead and run |
36462c9 to
9c35598
Compare
Ran |
This comment was marked as resolved.
This comment was marked as resolved.
|
Looks like you fixed it bitreq resolves to |
Closes #1642
The previous constraint (>=0.10.8, <0.10.10) was a workaround for
a breaking change accidentally backported into 0.10.10 upstream.
Move to 0.14.0.
This requires:
Nonefor the newoptions: Option<BroadcastOptions>parameter of
send_raw_transaction, added in the 0.10.10/0.14.0API change.
and rustls (0.23.31 -> 0.23.38) in payjoin, payjoin-mailroom,
and payjoin-test-utils, since bitreq (a transitive dependency of
bitcoind-async-client 0.14.0) requires these minimums and
direct-minimal-versions resolution fails otherwise.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.