-
Notifications
You must be signed in to change notification settings - Fork 2.3k
nodes: add MEP movement controls and DWV parity #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
3731eb3
Add roof surface placement support for items
sudhir9297 ed53bc2
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 fd8e02c
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 7c1e383
fixed conflict
sudhir9297 b3377da
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 f177a65
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 9af7491
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 fd27524
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 b516298
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 ebfc8ce
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 b7b313b
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 b2ad645
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 bffdb4a
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 ee7b10c
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 7d4b474
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 3a3318c
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 26df69f
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 cee84d0
feat(duct): ceiling-snap drawing + connected-joint endpoint move
sudhir9297 b8e2d5f
feat(mep): detach + vertical modifiers for duct/pipe joint editing
sudhir9297 37d5dfa
feat(mep): full DWV pipe parity for joint editing
sudhir9297 810f90c
feat(mep): wall-style arrow handles for duct fittings + segments
sudhir9297 2cb01c4
feat(mep): click-to-latch cube handles for duct + fitting editing
sudhir9297 126c1f0
fix(mep): orient duct roll arc consistently + drop Ctrl-vertical drag
sudhir9297 682bb99
feat(mep): run-aligned duct handles, swing snapping, elbow flatten
sudhir9297 9a5343f
feat(mep): per-segment linesets/liquid-lines with joint-follow editing
sudhir9297 7892a2d
feat(mep): vertical-offset auto-routing on duct center-cube ±Y drag
sudhir9297 64d8049
Add roof accessory placement guides
sudhir9297 7ac7c3e
Improve duct and placement routing
sudhir9297 4029100
Fix duct vertical movement routing
sudhir9297 d21ff63
Fix duct vertical offsets and roof accessory movement
sudhir9297 c8c8d04
Add DWV movement parity and line endpoint controls
sudhir9297 1cdc087
Merge branch 'main' of github.com:pascalorg/editor into fix/wed-jun-17
sudhir9297 b98c30a
Fix MEP handle review issues
sudhir9297 f70968f
Fix chimney placement and duct offset cleanup
sudhir9297 ba4dc2a
Use snapped targets for roof accessory commits
sudhir9297 a784946
fix(nodes): repair MEP movement review issues
open-pascal a1b0187
fix: address mep movement review issues
sudhir9297 dcd979a
fix: address follow-up mep review comments
sudhir9297 a20298f
fix: address additional mep review comments
sudhir9297 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trap button broken icon path
Low Severity
The new Add Trap control loads
/icons/dwv-pipes.png, but the app only shipsdwv-pipes.webp(same path as the DWV pipe tile). The trap affordance can show a missing image while the rest of the pipe UI uses the webp asset.Reviewed by Cursor Bugbot for commit a20298f. Configure here.