nom: switch to nom6-like errors#54
Open
cyphar wants to merge 2 commits into
Open
Conversation
Because we don't depend on "std" for "nom", the tests were failing to build if you only enabled the "nom" feature but not "std". So require both when testing (this is only needed for the tests). Signed-off-by: Aleksa Sarai <[email protected]>
The preferred error types were changed in nom 6, and while the old ones will compile, you'll find that nom doesn't like them very much any more. It's much more preferable to use the new errors. Signed-off-by: Aleksa Sarai <[email protected]>
Contributor
Author
|
/ping @tomaka |
|
Would love to see this merged ! |
|
ping @tomaka |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preferred error types were changed in nom 6, and while the old ones
will compile, you'll find that nom doesn't like them very much any more.
It's much more preferable to use the new errors.
Signed-off-by: Aleksa Sarai [email protected]