You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
DotNS deploys onto next-asset-hub-paseo, and its PoP controller has to recognise a substrate Root dispatch as an authority. The only root check in pallet-revive 0.18.0 is callerIsRoot, which answers only when the asking contract is the direct callee of the dispatch. The controller is a UUPS proxy, so its implementation runs inside the proxy's delegatecall and cannot ask the precompile from its own frame.
pallet-revive 0.18.1 adds originIsRoot, which returns true whenever the top-level dispatch was root regardless of how many contract or delegate-call frames separate the precompile from that dispatch. That lets the controller check root authority from inside its own proxy frame and it is the same mechanism any future governance-gated entrypoint on the registrar controller would use. The method was published from unstable2604 after the backport of paritytech/polkadot-sdk#12281 landed as paritytech/polkadot-sdk#12923. This is a lockfile-only update and it makes the new available to next-asset-hub-paseo, which has to ship for the method to exist on chain.
Changes
Cargo.lock: the three version bumps for pallet-revive, pallet-revive-uapi, pallet-revive-fixtures.
Five transitive windows-sys edges re-point from 0.61.2 to 0.59.0 as a resolver side effect
@kianenigma, we'll need to revisit pallet-revive when we take care of #10. It uses 0.19.0, which doesn't currently contain originIsRoot.
If necessary, I can backport paritytech/polkadot-sdk#12281 to some other (stable?) branch to have it in the ^0.19.0 releases
Yeah, would be nice if the upcoming polkadot-stable2606-2 had it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DotNS deploys onto next-asset-hub-paseo, and its PoP controller has to recognise a substrate Root dispatch as an authority. The only root check in pallet-revive 0.18.0 is callerIsRoot, which answers only when the asking contract is the direct callee of the dispatch. The controller is a UUPS proxy, so its implementation runs inside the proxy's delegatecall and cannot ask the precompile from its own frame.
pallet-revive 0.18.1 adds originIsRoot, which returns true whenever the top-level dispatch was root regardless of how many contract or delegate-call frames separate the precompile from that dispatch. That lets the controller check root authority from inside its own proxy frame and it is the same mechanism any future governance-gated entrypoint on the registrar controller would use. The method was published from unstable2604 after the backport of paritytech/polkadot-sdk#12281 landed as paritytech/polkadot-sdk#12923. This is a lockfile-only update and it makes the new available to next-asset-hub-paseo, which has to ship for the method to exist on chain.
Changes