fix(people-lite): reject alias accounts in attest - #19
Open
agustinustheo wants to merge 2 commits into
Open
Conversation
csmnprschv
approved these changes
Aug 20, 2026
| ) -> DispatchResultWithPostInfo { | ||
| let verifier = ensure_signed(origin)?; | ||
| ensure!(!LitePeople::<T>::contains_key(&candidate), Error::<T>::AlreadyRegistered); | ||
| ensure!(!AccountToAlias::<T>::contains_key(&candidate), Error::<T>::AccountInUse); |
Collaborator
There was a problem hiding this comment.
Add it to register_with_fee as well.
agustinustheo
force-pushed
the
fix/5-ta-reject-alias-accounts
branch
from
August 20, 2026 15:34
09aa847 to
273ea5f
Compare
Member
Author
|
I force pushed because I rebased with |
agustinustheo
enabled auto-merge (squash)
August 20, 2026 15:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
attestonly rejected accounts registered as lite people, so an account already bound to a lite alias could also become a canonical lite person.The call now rejects alias-bound candidates with
AccountInUsebefore registration. A regression test establishes a real alias binding and verifies that attestation leaves the binding and allowance unchanged.Changes
AccountToAliasgate toPeopleLite::attest.