perf: optimize fallback entity matching via lazy metadata caching (#805)#810
Open
suhaniiz wants to merge 1 commit into
Open
perf: optimize fallback entity matching via lazy metadata caching (#805)#810suhaniiz wants to merge 1 commit into
suhaniiz wants to merge 1 commit into
Conversation
|
@suhaniiz is attempting to deploy a commit to the param20h's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 PR Checklist
🔗 Related Issue
Closes #805
📝 What does this PR do?
This PR optimizes the fallback entity matching logic inside$O(N)$ full-graph sequential scans on every incoming fallback query.
_match_query_nodesto eliminate expensiveChanges introduced:
_name_to_node_id) cached directly inside the NetworkXgraph.graphmetadata dictionary.node_ids is pre-computed exactly once.🗂️ Type of Change
🧪 How was this tested?
uvicorn app.main:app --reload)📸 Screenshots (if UI change)
N/A
The lookup index is cleanly scoped within NetworkX's native
graphproperty metadata dictionary, meaning it remains tied to the lifetime of the graph object in memory without introducing global state bottlenecks or database mutation concerns.✅ Self-Review Checklist
dev, notmainmainbranch or any HuggingFace deployment config