refactor: hoist _node_name out of inner loop in get_entity_context (#806)#809
Open
suhaniiz wants to merge 1 commit into
Open
refactor: hoist _node_name out of inner loop in get_entity_context (#806)#809suhaniiz wants to merge 1 commit into
suhaniiz wants to merge 1 commit into
Conversation
|
@suhaniiz is attempting to deploy a commit to the param20h's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 PR Checklist
🔗 Related Issue
Closes #806
📝 What does this PR do?
This PR optimizes the performance of the knowledge graph retrieval phase within
get_entity_context.Previously, the statement
left = _node_name(graph, node_id)was evaluated inside the tight inner loop (for neighbor_id in neighbors:). Becausenode_idremains completely constant throughout the iteration of its neighbors, computing its string name repeatedly was redundant.This change hoists the
_node_nameevaluation up exactly one block level into the outer loop, caching the string value once per matched node. This saves significant CPU cycles when handling highly connected query graphs.🗂️ Type of Change
🧪 How was this tested?
uvicorn app.main:app --reload)📸 Screenshots (if UI change)
N/A
The refactor strictly alters where the variable assignment happens without modifying the underlying dictionary key generation or graph processing logic. No side effects or breaking changes are introduced.
✅ Self-Review Checklist
dev, notmainmainbranch or any HuggingFace deployment config