Some changes needed for android compilation #5#6
Conversation
panstromek
left a comment
panstromek
left a comment
There was a problem hiding this comment.
Huh, I totally missed this in notifications, sorry.
I'll try to run this through zebra-rs snapshot tests and merge if everything is ok. Thanks!
| getcwd(sPatternFile, sizeof(sPatternFile)); | ||
| strcat(sPatternFile, "/" PATTERN_FILE); | ||
| #endif | ||
| char* env_coeffs = getenv("COEFFS_PATH"); |
There was a problem hiding this comment.
I'd like to keep this, It's used in snapshot tests and fuzzer. Did you have problems with getenv on android?
There was a problem hiding this comment.
i don't think so. cant remember why i removed this, possible in a diff or something
| extern Board board; | ||
|
|
||
| #ifdef ANDROID | ||
| int droidzebra_message_debug(const char* format, ...); |
There was a problem hiding this comment.
not the nicest thing in the world but what can we do 🤷♂️
Ideally this project should not depend on droidzebra like this, so the function should be somehow injected from the outside, but we got no time for that business
There was a problem hiding this comment.
maybe this could just be a standard debug function like message_debug ...
2 participants
The changes made by #5 as a PR.