Skip to content

Drawing: Fix nothing from current recording shown during record - #259

Merged
panglesd merged 1 commit into
mainfrom
fix-no-drawing-when-recording
Jul 17, 2026
Merged

Drawing: Fix nothing from current recording shown during record#259
panglesd merged 1 commit into
mainfrom
fix-no-drawing-when-recording

Conversation

@panglesd

Copy link
Copy Markdown
Owner

The bug was introduced in #254: such a shame I can introduce bugs like this. I need a testing framework!

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 16237997-ea69-4369-a75d-cc0fa8b005ca

📥 Commits

Reviewing files that changed from the base of the PR and between f9bdcf9 and 90454f2.

📒 Files selected for processing (1)
  • src/engine/runtime/drawing/drawing_controller/preview.ml

📝 Walkthrough

Walkthrough

The drawing preview now renders two SVG drawing groups when the replaying recording ID matches the workspace recording ID. It passes recording_temp and replayed_part to act with no explicit time instead of returning an empty drawing sequence.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main fix: current recording content now renders during recording.
Description check ✅ Passed The description is relevant to the bug fix and references the introduced regression.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@panglesd
panglesd merged commit ba21bfd into main Jul 17, 2026
6 of 9 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant