Skip to content

Server info#258

Open
panglesd wants to merge 4 commits into
mainfrom
server-info
Open

Server info#258
panglesd wants to merge 4 commits into
mainfrom
server-info

Conversation

@panglesd

Copy link
Copy Markdown
Owner

Add server info (name and version), but and a "move_from_editor" advertised experiment capability so that editors can know if they can send such requests (and suggest to upgrade if the user tries to).

panglesd added 3 commits July 16, 2026 10:30
To be able to depend on it without any of the rest of slipshow
All capabilities will be an object with a version field, to be able to version
them.

Currently, no payload and no "formal" definition of the capability form, this
will be left for when there are many capabilities.
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 56f783e1-b094-4daa-aa28-6a5ab7e4c124

📥 Commits

Reviewing files that changed from the base of the PR and between f46e8f6 and 878944a.

📒 Files selected for processing (1)
  • src/lspishow/lspishow.ml
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/lspishow/lspishow.ml

📝 Walkthrough

Walkthrough

A public slipshow.version library now defines shared release metadata. The CLI uses this metadata for version reporting across its commands, replacing local constants. The LSP library depends on the shared version library and handles initialization directly, including server information, client position encoding, configured capabilities, and an experimental move_from_editor capability.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and clearly matches the main change: adding server info.
Description check ✅ Passed The description is directly related to the changes, mentioning server info and the new experimental capability.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
putComment timed out

@panglesd

Copy link
Copy Markdown
Owner Author

Par les pouvoirs qui me sont conférés, je demande une review de la part de codelapin ! ⚡

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

@panglesd Bien reçu — je relance une revue complète de la PR #258. 🐇⚡

✅ Action performed

Full review finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant