Ensure Date(Time)Picker does not clear on partial entry - #720
Open
philippjfr wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
==========================================
- Coverage 84.23% 83.67% -0.56%
==========================================
Files 34 34
Lines 3958 3958
==========================================
- Hits 3334 3312 -22
- Misses 624 646 +22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DatePicker/DatetimePickerupdateModelValueandhandleChangetreated "field is fully empty" (null) and "field is mid-edit with an incomplete section" (a non-null but structurally invalid dayjs object) identically. MUI fires onAccept on every keystroke for field-only edits (not just on blur/Enter), so typing a single digit into the year section immediately produced an invalid intermediate dayjs value, which the old code treated as "clear" whenever clearable=True — wiping the field and committing None to Python.This ensures an invalid partial date entry no longer triggers a clear and commit of None.