Record the metric-filter cleanup in the as-built notes and document the attach signal#222
Merged
Merged
Conversation
…he attach signal The Feature 4 as-built notes described the first cut, where the content-type gate and fail-open handling lived in AgentHttpService. They moved into MetricFilter.filterBytes() during the post-merge quality pass, along with the warn latches; the notes now match, and a new subsection records the three divergences and why each was made. Also documents the operator-facing consequence of deleting the startup filter/path cross-check: a filter whose path does not match a registered path is otherwise silent, so agent.md now shows the registration log line that reports attachment and says what its absence means. README and the agent.md fail-open note are unchanged -- they describe behavior that did not change. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs-only follow-up to #221. The Feature 4 as-built notes described the first cut of the feature, before the post-merge quality pass moved things around.
docs/FEATURE_PROPOSALS_JULY_2026.mdMetricFilternow ownsfilterBytes()(the content-type gate, strict UTF-8 decode, fail-open branches, and warn latches);AgentHttpServiceis reduced to calling it.AgentPathManagerreports filter attachment in the registration log.filterText(), and the deletion of the startup filter/path cross-check.isFilterableContentTypetests still live inAgentHttpServiceTestthough the function moved toMetricFilter.website/prometheus-proxy/docs/configuration/agent.mdAdded a "Confirming a filter attached" tip — the operator-facing consequence of deleting the startup cross-check. A filter whose
pathdoesn't match a registered path is otherwise silent, so the doc shows the exact registration log line and explains what its absence means. The example string was verified against the source.Unchanged on purpose
README and the
agent.mdfail-open note describe user-visible behavior, which did not change — "logs a warning once per path" still holds, since the filter instance the latch moved onto is 1:1 with a path. CHANGELOG and RELEASE_NOTES describe config surface and matching semantics, both untouched.🤖 Generated with Claude Code