Adding C++ modules support and CMake#1
Merged
Conversation
ozguronsoy
requested changes
Nov 21, 2025
ozguronsoy
left a comment
ozguronsoy
left a comment
Owner
There was a problem hiding this comment.
Thanks for adding modules and CMake support. Please address the highlighted parts and edit the test.yaml file so it can run the tests.
Contributor
Author
|
I think my changes should fix the mentioned issues |
ozguronsoy
requested changes
Nov 21, 2025
ozguronsoy
left a comment
ozguronsoy
left a comment
Owner
There was a problem hiding this comment.
Tests are failing to build, see the comments for more detail. You can also run the test workflow on your fork, it would be faster to debug.
Contributor
Author
|
OK, I have made changes and run the CI tests locally. I think this should work now. |
ozguronsoy
approved these changes
Nov 22, 2025
ozguronsoy
left a comment
ozguronsoy
left a comment
Owner
There was a problem hiding this comment.
Build issues are fixed, nice job. Merging, thanks for contributing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request splits the project files into
include/andsrc/, as well as adding C++ modules and options to toggle features through CMake.