diagnostics: say what stop-all deletes, flag missing server logs, unbreak bleep fmt - #634
Merged
Merged
Conversation
…reak bleep fmt Fallout from an OOM incident report against M10, where the evidence trail went cold twice: - `bleep config compile-server stop-all` deleted a socket dir holding 10GB of heap dumps without a word. It still deletes — that is its job — but now logs each dir with its size, at warn level when it was ≥1GB, so gigabytes of diagnostics no longer vanish silently. - The failure path printed `BSP server log: <path>` for a file that did not exist (server never started, or the dir was already cleaned), sending the reader to a dead end. Both call sites now say `(missing — …)` when the file is not there. Separately, `bleep fmt` failed repo-wide: scalafmt cannot parse a lambda whose body is an indented try/catch followed by `, arg` in the same call (ServerRunInterruptTest.scala, from #629). Verified against scalafmt 3.11.5 under dialects scala3/scala36/scala3future — none parse it, so the fix is binding the Runnable to a val first. Bumped scalafmt 3.11.1 → 3.11.5 while at it; zero reformat churn. Co-Authored-By: Claude Fable 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fallout from an OOM incident report against M10, where the evidence trail went cold twice:
bleep config compile-server stop-alldeleted a socket dir holding 10GB of heap dumps without a word. It still deletes — that is its job — but now logs each dir with its size, at warn level when it was ≥1GB, so gigabytes of diagnostics no longer vanish silently.The failure path printed
BSP server log: <path>for a file that did not exist (server never started, or the dir was already cleaned), sending the reader to a dead end. Both call sites now say(missing — …)when the file is not there.Separately,
bleep fmtfailed repo-wide: scalafmt cannot parse a lambda whose body is an indented try/catch followed by, argin the same call (ServerRunInterruptTest.scala, from #629). Verified against scalafmt 3.11.5 under dialects scala3/scala36/scala3future — none parse it, so the fix is binding theRunnableto avalfirst, with a comment so nobody simplifies it back. Bumped scalafmt 3.11.1 → 3.11.5 while at it; zero reformat churn.Verified locally:
bleep compilegreen,bleep fmtexits 0,ServerRunInterruptTest3/3 passed.🤖 Generated with Claude Code