Replaces yarn with npm#170
Conversation
| - CC_TEST_REPORTER_ID=0be009d55f19435b5d362efac7afcdc532945bbc13527c285135c5e7b84f4e3c | ||
| cache: | ||
| yarn: true | ||
| directories: |
There was a problem hiding this comment.
I think we still want to cache this?
There was a problem hiding this comment.
| - ./cc-test-reporter before-build | ||
| script: | ||
| - yarn && yarn test:coverage | ||
| - npm run test:coverage |
There was a problem hiding this comment.
You still need to install dependencies with npm ci. Might make sense to create an install step in travis so it can cache the install steps.
There was a problem hiding this comment.
Nvm, I see you updated it. Didn't we want to use npm ci? Also still might make sense to do that in the install step instead of script so travis can cache it.
There was a problem hiding this comment.
travis runs npm ci instead of npm install: https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#npm-ci-support
|
|
||
| ``` | ||
| yarn start | ||
| npm start |
There was a problem hiding this comment.
Don't these commands become npm run ...?
There was a problem hiding this comment.
there are a few reserved words that just run without needing to add run
|
Is yarn.lock added to .gitignore? |
|
@CKH4 I am completely removing yarn, so there should no longer be a yarn.lock file |
|
I think we should blacklist yarn.lock so that we only have the preferred lock file in the repo. @EdmundMai @AaronVasquez What do you think? |
|
@CKH4 I don't think it'll be necessary since we're just not going to use yarn + package-lock.json will be there so it will indicate we use npm |
3 participants
No description provided.