fix: Replace deprecated String.prototype.substr()#733
Merged
phil-davis merged 1 commit intoJul 10, 2026
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
dj4oC
reviewed
Jul 9, 2026
dj4oC
left a comment
dj4oC
left a comment
Contributor
There was a problem hiding this comment.
- Security: no findings — mechanical
.substr()→ replacement, no logic change intended - Stability: stale since Apr 2022, no CI signal available for this pass
- Performance: no findings
- Test coverage: no tests added; pure syntax-level refactor, low risk
- TODOs found: 0
- Dependency touched: no
- CI status: unknown/stale
Verdict
Low-risk change in principle, but stale for 4+ years and needs a rebase + fresh CI run before it's mergeable. Not blocking, just needs owner attention.
🤖 Automated review by Claude Code (security · stability · performance · coverage)
Generated by Claude Code
CommanderRoot
force-pushed
the
refactor/rm-deprecated-substr
branch
from
b09dd8e to
32f3394
Compare
Contributor
Author
|
Rebased against current master as requested by our overlords |
.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated Signed-off-by: Tobias Speicher <[email protected]>
phil-davis
changed the title
phil-davis
force-pushed
the
refactor/rm-deprecated-substr
branch
from
32f3394 to
c043d4f
Compare
Contributor
|
I adjusted the commit and PR title to meet the semantic commit rules. |
phil-davis
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.