Replacement for some vcard tel type#624
Open
Terge3141 wants to merge 2 commits into
Open
Conversation
…s sent by CardDAV-Sync
Codecov Report
@@ Coverage Diff @@
## master #624 +/- ##
==========================================
- Coverage 18.72% 18.49% -0.24%
==========================================
Files 51 51
Lines 1036 1049 +13
==========================================
Hits 194 194
- Misses 842 855 +13
Continue to review full report at Codecov.
|
dj4oC
reviewed
Jul 9, 2026
dj4oC
left a comment
dj4oC
left a comment
Contributor
There was a problem hiding this comment.
- Security: not assessable without a fresh diff against current
master(PR is from Nov 2017) - Stability: 9 years stale, predates the current CI/CLA/review tooling entirely.
- Performance: n/a
- Test coverage: unknown
- TODOs found: 0 tracked
- Dependency touched: no
- CI status: none available
Verdict
Recommend closing as long-abandoned. If the underlying vCard TEL type issue is still valid, it should be re-filed against current code rather than resurrecting this branch.
🤖 Automated review by Claude Code (security · stability · performance · coverage)
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following 'tel' types are not shown correctly for a contact:
TYPE=VOICE;TYPE=CELL and TYPE=VOICE;TYPE=HOME
Both are shown as 'VOICE', on Android as Mobile and Home, respectively
Suggestion to change types:
TYPE=VOICE;TYPE=CELL --> CELL
TYPE=VOICE;TYPE=HOME --> HOME,VOICE
Example (sent by Android CardDAV-Sync free 0.4.201):
BEGIN:VCARD
VERSION:3.0
TEL;TYPE=VOICE;TYPE=HOME:41111
BDAY:2017-11-10
FN:CopyTest
TEL;TYPE=VOICE;TYPE=CELL:31111
UID:52e91035-f94a-4e5d-81cc-4d75bf07a0c7
N:;CopyTest;;;
PRODID:-//dmfs.org//mimedir.vcard//EN
REV:20171112T211147Z
END:VCARD