Bump gulp from 3.9.1 to 5.0.1#1349
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Bumps [gulp](https://github.com/gulpjs/gulp) from 3.9.1 to 5.0.1. - [Release notes](https://github.com/gulpjs/gulp/releases) - [Changelog](https://github.com/gulpjs/gulp/blob/master/CHANGELOG.md) - [Commits](gulpjs/gulp@v3.9.1...v5.0.1) --- updated-dependencies: - dependency-name: gulp dependency-version: 5.0.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
Bot
added
dependencies
javascript
phil-davis
pushed a commit
that referenced
this pull request
Jul 9, 2026
…s deps (#1361) The karma test suite runs on Firefox (tests/js/config/karma.js, gulpfile.js); `karma-phantomjs-launcher` and `phantomjs-prebuilt` were unreferenced anywhere except package.json. `phantomjs-prebuilt` was the SOLE path pulling in the vulnerable request -> tough-cookie / uuid chain. Removing both dead dev deps eliminates those transitive packages entirely. Fixed (packages removed from the dependency tree): - request 2.88.2 removed (#58, SSRF, GHSA-p8p7-x288-28g6; deprecated, no fix) - tough-cookie 2.5.0 removed (#64, prototype pollution, needs >= 4.1.3) - uuid 3.4.0 removed (#129, buffer bounds check, needs >= 11.1.1) Verified: `yarn install --frozen-lockfile` clean, `yarn build` (gulp) green. Test suite runs on Firefox inside an ownCloud core checkout (CI: xvfb) and is unaffected — the removed packages play no role in the karma runtime. Not fixable here (no upstream fix / would need a major migration): - angular / angular-sanitize (#43,#46,#59,#60,#61,#73,#84,#85,#90,#91) — AngularJS 1.x is EOL; all first_patched are null. Real remediation is a framework migration off AngularJS. - babel-traverse 6.26.0 (#76, critical) — only @babel/traverse 7.x is patched; needs babel 6 -> 7 toolchain migration. - lodash.template 3.6.2 (#77, high) — pulled by gulp-util/gulp 3.x; no patched line, deprecated. Resolved by the pending gulp 3 -> 5 upgrade (#1349). Signed-off-by: Thomas Müller <[email protected]>
dj4oC
reviewed
Jul 9, 2026
dj4oC
left a comment
dj4oC
left a comment
Contributor
There was a problem hiding this comment.
- Security: no findings (gulp 3.9.1 → 5.0.1, build-tooling devDependency)
- Stability: CI red on
Commits / Validate semantic commitsandbuild / Build;JS Unit/PHP jobs pass. gulp 3→5 is a major bump of the build tool itself — worth confirming the build actually still runs after this, sincebuild/Buildis failing. - Performance: no findings
- Test coverage: n/a (dependency bump)
- TODOs found: 0
- Dependency touched: yes — gulp (MIT), major bump
- CI status: failing (Commits, build)
Verdict
Not mergeable as-is — build check is red. Not approving until CI is green.
🤖 Automated review by Claude Code (security · stability · performance · coverage)
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps gulp from 3.9.1 to 5.0.1.
Release notes
Sourced from gulp's releases.
... (truncated)
Changelog
Sourced from gulp's changelog.
... (truncated)
Commits
0003e9fchore: release 5.0.1 (#2837)19122f3fix: Avoid globbing before read stream is opened (#2839)69a5d0efix: Avoid Node.js deprecation warning forfs.Stats(#2838)04b4a74fix: Support top-level await on Node 22.12+ (#2836)c90e79echore: Fix CI (#2835)5412605chore(docs): Update async completion document for newer RxJS (#2831)2fa4981chore: Update glob docs with replacement to ordered globs (#2788)fe9dee6chore: Remove locale docs (#2787)a85eddbchore: Remove node-glob options from docs (#2786)9c818e6chore: update src.md docs to add encoding parameterYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)