fix: rolling build fails on removed web make pull-assets target#31
Merged
Conversation
The scheduled Docker Rolling build broke because `v8/Dockerfile.multiarch`
runs `make pull-assets` in `services/web`, and upstream removed that target
from oCIS master.
owncloud/ocis commit 6bad03d3 ("merge and relicense ownCloud Web into oCIS",
#12491) imported the ownCloud Web frontend in-tree as a pnpm workspace under
`web/` and rewrote `services/web/Makefile`: the `pull-assets` target (which
downloaded a `web.tar.gz` release tarball from owncloud/web) was replaced by
`build-assets`, which builds the assets from the in-tree source with pnpm.
On master `pull-assets` no longer exists, so the step exits 2.
This Dockerfile is shared by both workflows: rolling.yml checks out master
(needs `build-assets`, ships in-tree web/) while main.yml checks out release
tags v8.0.5 / v8.1.0 (still ship `pull-assets`, no in-tree web/). Branch on
the presence of `web/package.json`, mirroring the existing services/idp
no-npm handling, so both paths keep working.
Co-Authored-By: Claude Opus 4.8 <[email protected]>
Signed-off-by: Thomas Müller <[email protected]>
kobergj
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The scheduled Docker Rolling build is failing:
(run 28919577223)
Root cause
v8/Dockerfile.multiarchrunsmake pull-assetsinservices/web, but upstream removed that target from oCIS master.owncloud/ocis commit
6bad03d3— "[full-ci] chore: merge and relicense ownCloud Web into oCIS" (#12491), merged 2026-07-07 — imported the ownCloud Web frontend in-tree as a pnpm workspace underweb/and rewroteservices/web/Makefile:pull-assets→ downloaded aweb.tar.gzrelease tarball fromowncloud/webbuild-assets→ builds assets from the in-treeweb/source with pnpmOn master
pull-assetsno longer exists, so the step exits 2. This is the same "no-npm / in-tree" refactor already handled forservices/idpin this Dockerfile.Fix
This Dockerfile is shared by both workflows:
web/rolling.ymlbuild-assetsmain.ymlpull-assetsBranch on the presence of
web/package.json, mirroring the existingservices/idpno-npm conditional, so both the rolling (master) and release (tagged) builds keep working.Verification
rolling.ymltriggers on PRs touchingv8/Dockerfile.multiarchwithpush: false, so this PR's CI runs the real master build without publishing.🤖 Generated with Claude Code