Skip to content

Could not set OWNCLOUD_SKIP_CHOWN from values#77

Open
gulecroc wants to merge 2 commits into
owncloud-docker:mainfrom
gulecroc:main
Open

Could not set OWNCLOUD_SKIP_CHOWN from values#77
gulecroc wants to merge 2 commits into
owncloud-docker:mainfrom
gulecroc:main

Conversation

@gulecroc

Copy link
Copy Markdown

Fixto set OWNCLOUD_SKIP_CHOWN from values

@henb

henb commented Aug 18, 2025

Copy link
Copy Markdown

Hello @xoxys @d7oc, please check PR , maybe can we merge it?

@DeepDiver1975 DeepDiver1975 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes a real bug: OWNCLOUD_SKIP_CHOWN was hardcoded to "true" in the ConfigMap template, making it impossible to configure from values.yaml. The fix correctly wires it to {{ .Values.owncloud.skipChown | quote }}, matching the pattern used for all surrounding env vars (e.g. OWNCLOUD_SKIP_CHMOD).

One thing to verify: ensure owncloud.skipChown has a default defined in values.yaml. If it defaults to an empty string, the env var would be set to "" rather than "false", which may or may not behave the same depending on how the container interprets it. If the intent is that chown runs by default (i.e. skipChown: false), confirm values.yaml has skipChown: false explicitly so existing deployments aren't surprised by a behaviour change after upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants