AO3-7388 Redirect to user skin page with error if trying to preview a skin you can't use#5813
Open
brianjaustin wants to merge 1 commit into
Open
AO3-7388 Redirect to user skin page with error if trying to preview a skin you can't use#5813brianjaustin wants to merge 1 commit into
brianjaustin wants to merge 1 commit into
Conversation
… skin you can't use This reverts commit 8c294d1. Co-authored-by: Lim Zhe Rui <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 8c294d1. It reintroduces #5776.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7388
Purpose
Redirects to the user skins page when trying to preview a skin that can't be used but can be viewed while logged in as a user. This includes parent-only site skins and work skins. For skins that a logged-in user cannot view (not owned and not public), they are redirected to their dashboard with an error.
Changed preview to a user-only action. Redirects to the login page with an error when trying to preview any skin while logged out. Redirects to the root page with an error when trying to preview any skin while logged in as an admin.
Testing Instructions
For site skins, refer to Jira.
For work skins:
a. Hi, username! > My Dashboard > Skins > Create Work Skin
b. Fill in required information
c. Press “Submit” to save
For not owned, not public skins:
a. Hi, username! > My Dashboard > Skins > Create Site Skin
b. Fill in required information
c. Press “Submit” to save
Credit
zrei (she/they)