Keep empty mapped fields out of the ticket body#368
Merged
Conversation
extract_custom_fields added a form field to the consumed set only after confirming it had a value, so a mapped-but-empty field (e.g. an unfilled SSH key) was never marked consumed and still appeared in the ticket body as a blank line. Mark any well-formed mapping entry consumed before the empty-value check, so the field is omitted from the body whether or not it has a value; only the custom-field assignment is skipped when empty. Co-Authored-By: Claude Opus 4.8 <[email protected]> Signed-off-by: Lance Albertson <[email protected]>
Add Python 3.14 to the CI matrix so the test suite runs on it alongside 3.12 and 3.13. The runtime image already runs on python:3.14-alpine, so this keeps CI aligned with what ships. Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extract_custom_fields added a form field to the consumed set only after
confirming it had a value, so a mapped-but-empty field (e.g. an unfilled
SSH key) was never marked consumed and still appeared in the ticket body
as a blank line. Mark any well-formed mapping entry consumed before the
empty-value check, so the field is omitted from the body whether or not
it has a value; only the custom-field assignment is skipped when empty.
Co-Authored-By: Claude Opus 4.8 [email protected]
Signed-off-by: Lance Albertson [email protected]