🐛 Change Mkdir to MkdirAll when extracting tarball#5039
Open
juanis2112 wants to merge 3 commits into
Open
Conversation
juanis2112
requested review from
AdamKorcz and
spencerschrock
and removed request for
a team
dosubot
Bot
added
the
size:S
juanis2112
had a problem deploying
to
integration-test
GitHub Actions
Failure
juanis2112
had a problem deploying
to
integration-test
GitHub Actions
Failure
Bumps [github.com/sigstore/timestamp-authority/v2](https://github.com/sigstore/timestamp-authority) from 2.0.3 to 2.0.6. - [Release notes](https://github.com/sigstore/timestamp-authority/releases) - [Changelog](https://github.com/sigstore/timestamp-authority/blob/main/CHANGELOG.md) - [Commits](sigstore/timestamp-authority@v2.0.3...v2.0.6) --- updated-dependencies: - dependency-name: github.com/sigstore/timestamp-authority/v2 dependency-version: 2.0.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: juanis2112 <[email protected]>
Signed-off-by: juanis2112 <[email protected]>
juanis2112
had a problem deploying
to
integration-test
GitHub Actions
Failure
dosubot
Bot
removed
the
size:S
dosubot
Bot
added
the
size:L
juanis2112
had a problem deploying
to
integration-test
GitHub Actions
Failure
dosubot
Bot
added
size:S
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5039 +/- ##
==========================================
+ Coverage 66.80% 68.25% +1.45%
==========================================
Files 230 252 +22
Lines 16602 15734 -868
==========================================
- Hits 11091 10740 -351
+ Misses 4808 4136 -672
- Partials 703 858 +155 🚀 New features to boost your workflow:
|
|
This pull request has been marked stale because it has been open for 10 days with no activity |
|
This pull request has been marked stale because it has been open for 10 days with no activity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix: This PR changes Mkdir to MkdirAll when extracting tarball to avoid errors when tarballs contain file entries that share a parent directory.
What is the current behavior?
When running Scorecard against certain repositories, the tool exits early with an internal error due to a mkdir: file exists error during tarball extraction. This causes the repository to be skipped entirely.
What is the new behavior (if this is a feature change)?
If tarballs contain file entries that share a parent directory, the is no error returned.
Which issue(s) this PR fixes
Fixes #5023
Does this PR introduce a user-facing change?
NONE