bootc: support grub2 serial console customization#2403
Open
jbtrystram wants to merge 1 commit into
Open
Conversation
jbtrystram
force-pushed
the
blueprint_add_bootloader_grub_options
branch
2 times, most recently
from
9d7b50c to
b1afdd7
Compare
Member
|
@jbtrystram I'll mark this one as draft until we land the required |
jbtrystram
force-pushed
the
blueprint_add_bootloader_grub_options
branch
from
b1afdd7 to
80612a9
Compare
Contributor
Author
|
@supakeen I see the blueprints changes have been released so I guess this can be reviewed ? I just noticed the |
Member
Yea, you can undraft. |
supakeen
previously approved these changes
Jul 9, 2026
joelcapitao
suggested changes
Jul 9, 2026
joelcapitao
left a comment
joelcapitao
left a comment
Contributor
There was a problem hiding this comment.
I tested this PR alongside other PRs I have and got:
============================================================
=== Processing artifact: qemu for x86_64
============================================================
IMAGE_TYPE: qcow2
MEDIA_TYPE: application/vnd.diskimage.qcow2
=== Pre-merged blueprint for qemu ===
name = "Fedora CoreOS"
[customizations]
[customizations.ignition]
[customizations.ignition.firstboot]
empty = true
[customizations.kernel]
append = "mitigations=auto,nosmt $ignition_firstboot ignition.platform.id=qemu console=tty0 console=ttyS0,115200n8"
[customizations.bootloader]
[customizations.bootloader.grub2]
terminal_input = ["serial", "console"]
terminal_output = ["serial", "console"]
serial = "serial --speed=115200"
=== Building qemu disk image ===
Manifest generation step
Building manifest for bootc-based-qcow2
Using disk.yaml root filesystem (xfs), ignoring bootc config (xfs)
Image building step
<stdin> has errors:
.pipelines[2].stages[7].options:
'path' is a required property
error: error running osbuild: exit status 2
ERROR: Failed to build qemu
80612a9 to
cb7d8ac
Compare
Wire the blueprint bootloader customization into the bootc disk image pipeline. When blueprint specifies grub2 serial/terminal settings, emit an org.osbuild.grub2.d stage that writes a drop-in config to `boot/grub2/console.cfg` after bootc install-to-filesystem. This relies on `bootupd`'s `console.cfg` grub config: https://github.com/coreos/bootupd/blob/main/src%2Fgrub2%2Fgrub-static-pre.cfg#L41 This adds a Go wrapper for the new osbuild stage and reads `GetBootloader()` in the bootc image type. Assisted-by: Opencode.ai <Opus 4.6> Requires: osbuild/blueprint#53 Requires: osbuild/osbuild#2473
jbtrystram
force-pushed
the
blueprint_add_bootloader_grub_options
branch
from
cb7d8ac to
90ca81e
Compare
supakeen
approved these changes
Jul 10, 2026
supakeen
left a comment
supakeen
left a comment
Member
There was a problem hiding this comment.
Mmm I still had the default path value in my head too :)
joelcapitao
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire the blueprint bootloader customization into the bootc disk image pipeline.
When blueprint specifies grub2 serial/terminal settings, emit an org.osbuild.grub2.d stage that writes a drop-in config to
boot/grub2/console.cfgafter bootc install-to-filesystem.This relies on
bootupd'sconsole.cfggrub config: https://github.com/coreos/bootupd/blob/main/src%2Fgrub2%2Fgrub-static-pre.cfg#L41This adds a Go wrapper for the new osbuild stage and reads
GetBootloader()in the bootc image type.Assisted-by: Opencode.ai <Opus 4.6>
Requires: osbuild/blueprint#53
Requires: osbuild/osbuild#2473