build: restore BuildOptions.Version for selecting the builder#667
build: restore BuildOptions.Version for selecting the builder#667amitmishra11 wants to merge 1 commit into
Conversation
v3's BuildOptions had a Version field ("1" for classic, "2" for
BuildKit) that was dropped during the v4 moby client rewrite, even
though the underlying client.ImageBuildOptions already supports it.
Add it back and pass it through.
Fixes ory#663
This PR was written primarily by Claude Code; I reviewed the change
and ran the build test suite against a local Docker daemon before
submitting.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
2 participants
This PR was written primarily by Claude Code; I reviewed the change and ran the build test suite against a local Docker daemon before submitting.
Problem
v3's
BuildOptionshad aVersionfield controlling which builder the daemon uses ("1" for classic, "2" for BuildKit, added in #416). That field is missing from v4'sBuildOptions, even though the underlyingmobyclient.ImageBuildOptions(used internally) already has an equivalentVersion build.BuilderVersionfield. The v4 rewrite (#631) just never carried it over.Fix
Version stringback toBuildOptions(build.go), matching v3's field name, type, and doc comment.build.BuilderVersion(buildOpts.Version)toimageBuildOpts.Version.Testing
TestBuildAndRunWithBuildKit, which builds and runs an image withVersion: "2"set, following the same pattern as the existingTestBuildAndRun*tests.TestBuild*suite against a local Docker daemon: all 6 tests pass, including the new one.go build ./...,go vet ./...clean.Fixes #663