Skip to content

Close portfolio menu on navigation #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orlantquijada merged 2 commits into from
Jun 30, 2026
Merged

Close portfolio menu on navigation #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7287608
Close menu on portfolio navigation
orlantquijada Jun 30, 2026
da075e8
Fix daily API route params type
orlantquijada Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion apps/daily/src/app/api/[month]/[day]/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
import { getDaily, isValidDate } from "@/lib/content";
import { tryCatch } from "@/lib/utils";

export async function GET(_: Request, ctx: RouteContext<"/api/[month]/[day]">) {
type Params = {
params: Promise<{ month: string; day: string }>;
};

export async function GET(_: Request, ctx: Params) {
const { month, day } = await ctx.params;

// Validate against the known content set before importing, and keep the 404
Expand Down
2 changes: 1 addition & 1 deletion apps/portfolio-v2/src/components/Menu/Menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export function Menu() {
}}
variants={panelVariants}
>
<MenuPanel />
<MenuPanel onNavigate={() => setOpen(false)} />
</motion.div>
</PopoverPrimitive.Content>
</PopoverPrimitive.Portal>
Expand Down
8 changes: 4 additions & 4 deletions apps/portfolio-v2/src/components/Menu/MenuPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ import { GITHUB, LINKED_IN } from "@/utils/constants";
import ContactDialog from "../Contact/ContactDialog";
import styles from "./styles.module.css";

export function MenuPanel() {
export function MenuPanel({ onNavigate }: { onNavigate: () => void }) {
return (
<div className="mt-10 flex flex-col gap-8">
<Nav />
<Nav onNavigate={onNavigate} />

<div>
<h4 className="mb-3 text-gray10 dark:text-gray11">Connect</h4>
Expand Down Expand Up @@ -139,13 +139,13 @@ const links: Array<{
{ href: "/work", label: "Work", color: "bg-accent-violet" },
];

function Nav() {
function Nav({ onNavigate }: { onNavigate: () => void }) {
return (
<nav>
<ul className="flex flex-col">
{links.map((link) => (
<li key={link.label}>
<a className="font-medium" href={link.href}>
<a className="font-medium" href={link.href} onClick={onNavigate}>
<MenuItem
Icon={
<ArrowRight
Expand Down
Loading