fix(security): kubectl mutation order and binary surface#205
Merged
Conversation
Scaling a reconciled deployment is immediately undone by the Orkestra reconciler restoring the CR's replica count. Use a standalone nginx deployment that the fixture creates, scales, and deletes itself.
This reverts commit 816ca06.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkKubectlmutations now run inapply → patch → restart → scale → deleteorder before assertions —deletewas executing beforescale, breaking any step that combined both in the same block.resolveOCIRunPathmoved from untaggedfiles.gotofiles_dev.go(!runtime && !gateway) — untagged files compile into all three binaries and must stay free of dev-only symbols perdocumentation/security/01-binaries.md.