PE hyperstack: generalize reflect roster beyond brand-marketing (8 archetypes) - #131
Merged
Merged
Conversation
…lection loopholes Reflect claimed 'review AS a real target customer' but all 4 archetypes were marketing-ecosystem lenses around one creator-marketing context. Roster now spans the customer species (8 archetypes, Morgan still default for brand/marketing-shaped products): - kenji: senior backend eng, devtool buyer (docs-first, failure modes, exit paths; catches magic without observability, vague pricing) - sandra: enterprise IT / security procurement (SSO/SCIM, SOC 2, audit logs, DPA; catches security handwaves) - zoe: consumer mobile user (8-second patience; catches onboarding friction, permission grabs, dark patterns, paywall ambush) - sam: screen-reader user, accessibility lens (focus order, names, contrast; catches unlabeled buttons, focus traps, div-soup) MCP-served contract de-brand-hardcoded: Worried mood now triggers on the risk each archetype OWNS; in-head check 3 generalized to owned-risk; market-point rule generalized to the product's own category; samples corpus gains Kenji/Sandra/Sam registers; lens-selection rule added to voice-and-moods (served by reflect_get_voice_rules). Loopholes from live pressure test closed: 'switch on request' retitled 'match to the product's buyer'; 'before defaulting' rewritten so explaining a lens never licenses defaulting to Morgan; explicit lens-selection section added first in the skill. Pressure evidence: unlabeled 'review as a real user' on a devtool landing page - agent picked Kenji per the new wording, held the ONE RULE (reaction-first, moody, decisive call), review hit docs/pricing/Calendly exactly in-lens. Roster test updated to 8 ids; all 8 snippet docs verified resolving via getArchetypeDoc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reflect claimed "review AS a real target customer" but its whole roster was one customer species - four marketing-ecosystem lenses (brand approver, performance marketer, brand custodian, campaign operator) written around a single creator-marketing-fintech context. A devtool, enterprise, consumer, or accessibility screen had no correct reviewer. This PR generalizes the roster to 8 archetypes, de-brand-hardcodes the MCP-served voice contract, and closes lens-selection loopholes caught by a live pressure test.
New archetypes
kenjisandrazoesamMorgan stays default - but only for brand/marketing-shaped products.
Contract corrections (MCP-served ground truth was brand-hardcoded)
rules/voice-and-moods.txtreflect_get_voice_rulesexamples/samples.txtskills/reflect/SKILL.mdPressure-test evidence
Scenario: "review this screen as a real user" (no archetype named) on a devtool landing page (buzzword hero, Calendly-only CTA, no docs, no pricing).
Verification
bun test: 86 pass, 0 fail (roster test updated to the 8-id contract)getArchetypeDoc(runtime check: OK, 513-1598 chars each)bun run compile:context: succeeds; bootstrap bullet updated