Release v0.12.1: fix distributed install#27
Merged
Merged
Conversation
Bun installs peer deps into the plugin's node_modules, and the local .d.ts stubs shadow the host's runtime module intercepts. The host provides solid-js, @opentui/solid, and @opentui/core at runtime via ensureRuntimePluginSupport.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.12.0 broke when installed via git URL. Bun resolved
@opentui/solid/jsx-runtimeto the local.d.tsstub instead of the host's runtime module because the peer deps got installed into the plugin'snode_modules/.Removes
solid-js,@opentui/solid, and@opentui/corefrom peer deps. The host provides them at runtime.