Skip to content

fix(aws-util): use current session partition in GetRoleArn #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nlang wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(aws-util): use current session partition in GetRoleArn #616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/util/aws-util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,14 @@ export class AwsUtil {
}

public static GetRoleArn(accountId: string, roleInTargetAccount: string): string {
return 'arn:aws:iam::' + accountId + ':role/' + roleInTargetAccount;
// Use the current session's partition (cached during Initialize via
// GetPartitionFromCurrentSession). Falls back to 'aws' so the
// commercial-partition path is unchanged. Without this, partitions
// like aws-eusc (European Sovereign Cloud) or aws-cn produce ARNs
// that fail cross-account AssumeRole because they reference the
// commercial partition instead of the running one.
const partition = AwsUtil.partition ?? 'aws';
return `arn:${partition}:iam::${accountId}:role/${roleInTargetAccount}`;
}

private static GetPartitionRoleArn(accountId: string, roleInTargetAccount: string): string {
Expand Down