Skip to content

Fix v2 assets missing from distributions#5

Open
dev2703 wants to merge 1 commit into
orcahand:mainfrom
dev2703:orcasim-packaging-fix
Open

Fix v2 assets missing from distributions#5
dev2703 wants to merge 1 commit into
orcahand:mainfrom
dev2703:orcasim-packaging-fix

Conversation

@dev2703

@dev2703 dev2703 commented Jul 15, 2026

Copy link
Copy Markdown

Summary

  • add the four targeted package-data patterns required by the v2 model layout
  • add a wheel-level regression test that compares packaged model data with the source tree, installs the wheel outside the checkout, and resets both v1 and v2 environments
  • run the existing suite and wheel smoke test on pull requests

Closes #3.

Reproduction and verification

Before this change, a clean wheel install omitted 96 v2 files and OrcaHandRight(version=\"v2\").reset() failed while loading models/v2/assets/scene.xml.

After this change:

  • all 342 source .xml, .mjcf, and .stl data files are present in both the wheel and sdist (0 missing)
  • the newly covered v2 layout contributes the expected 96 files: 90 meshes, 4 XML files, and 2 MJCF files
  • clean wheel-installed OrcaHandRight environments reset successfully for both version=\"v1\" and version=\"v2\"
  • the full test suite passes (32 tests)

Downstream impact

orca_teleop exposes orca_sim from main through its optional sim dependency. The missing wheel assets make its v2 simulation sink unusable from a clean install; restoring distribution integrity unblocks that path.

This change validates packaged simulation only. It does not claim teleoperation or physical hardware validation.

Test plan

  • python -m pytest
  • python -m build
  • inspect wheel and sdist model-data coverage
  • install the wheel in a clean virtual environment outside the source tree
  • reset v1 and v2 right-hand environments from the installed wheel

Made with Cursor

Add wheel-level coverage so clean installs continue to initialize both supported hand versions.

Co-authored-by: Cursor <[email protected]>

@dev2703 dev2703 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a packaging issue. XML file error has been resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v2 model assets dropped from packaged wheel (package-data globs miss the v2 layout)

1 participant