fix(dashboard): persist lastRun so scheduling KPIs stay in sync#327
Closed
RaminGe wants to merge 1 commit into
Closed
fix(dashboard): persist lastRun so scheduling KPIs stay in sync#327RaminGe wants to merge 1 commit into
RaminGe wants to merge 1 commit into
Conversation
lastRun was only updated on the startup settings object while the dashboard reads a rebuilt cache after upsertSettings invalidates it.
Owner
|
Hey @RaminGe there was already a pr in the past which I closed. See #303 It's correct that this is not stored in the settings, simply because it is not a setting. I have not seen a value yet in storing this information in the db, but if I would, I certainly would store it as part of the job :) I'll keep your change in mind and will do it at a later stage. Thanks for your contribution though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lastRun was only updated on the startup settings object while the dashboard reads a rebuilt cache after upsertSettings invalidates it.
Fixes: #324