62 spatial data update#73
Open
karinpatenge wants to merge 8 commits into
Open
Conversation
Not yet complete
First review and update y Spatial and Graph PM team finished
Findings: 1. The SDO_GTYPE table is materially wrong and will teach the wrong encodings. In /tmp/spatial-data-pr73.md:44, 2004/3004 are labeled as polygons instead of collections, 2005/3005 are labeled as multipoints but mapped to point constants, and the 2006/3002 rows are duplicated/mislabeled. This is core reference material, so a reader copying it will build bad geometries.
List of findings corrected: 1. Several SQL examples are not runnable as written. In /tmp/spatial-data-pr73.md:489, the 3D USER_SDO_GEOM_METADATA example is missing commas between SDO_DIM_ELEMENT calls. 2. In /tmp/spatial-data-pr73.md:657, ALTER INDEX sp_idx refers to an index name that was never created in the snippet. 3. In /tmp/spatial-data-pr73.md:1444, 53,653 is not a valid numeric literal, and /tmp/spatial-data-pr73.md:1480 has a corrupted AND´s.is_open predicate. 4. In /tmp/spatial-data-pr73.md:1774, the SDO_DIFFERENCE example repeats m1 and references undefined aliases. These are copy/paste blockers.
Corrected finding: The tolerance guidance is internally inconsistent and the units explanation is wrong or at least misleading. /tmp/spatial-data-pr73.md:464 says geographic tolerance is in "unit-spheres" and recommends 0.005, but later examples use 1 with comments claiming "1 meter tolerance." A user following this section will not get a coherent setup for metadata and validation.
Rewrite of the opening support/licensing statement.
Author
|
Please review the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spatial-data.mdreviewed and updated by Spatial PM