Skip to content
This repository was archived by the owner on Jan 9, 2020. It is now read-only.

Implement eq and as_str in LinuxCapabilityType#37

Open
josselinchevalay wants to merge 1 commit into
oracle:masterfrom
josselinchevalay:master
Open

Implement eq and as_str in LinuxCapabilityType#37
josselinchevalay wants to merge 1 commit into
oracle:masterfrom
josselinchevalay:master

Conversation

@josselinchevalay

Copy link
Copy Markdown

i created an issue #36

for solved that i propose this pull request let me know your advice.

Regards

@drahnr

drahnr commented Sep 17, 2018

Copy link
Copy Markdown
Contributor

Is anything blocking this right now?

@vishvananda

Copy link
Copy Markdown
Contributor

I don't believe @josselinchevalay has signed the CLA so I can't merge. That said, I don't follow the updated logic. If difference is working properly, the if statement on the second line should always be false.

@drahnr

drahnr commented Sep 17, 2018

Copy link
Copy Markdown
Contributor

I did not look into the code itself, just wondering why this is dangling :)

@josselinchevalay

Copy link
Copy Markdown
Author

hi all,

yep second if statement seems return false always, i didn't why ? for CLA how to signed ?

Regards

@vishvananda

Copy link
Copy Markdown
Contributor

Instructions and a link to the OCA info can be found on the contributing page:

https://github.com/oracle/railcar/blob/master/CONTRIBUTING.md

@vishvananda

Copy link
Copy Markdown
Contributor

but yes i still don't think this new logic is correct.

@drahnr

drahnr commented Jun 22, 2019

Copy link
Copy Markdown
Contributor

@josselinchevalay it's been a while, any news?

@josselinchevalay

Copy link
Copy Markdown
Author

@drahnr nop i need to sign CLA. do you have same issue ?

@drahnr

drahnr commented Jul 23, 2019

Copy link
Copy Markdown
Contributor

I already signed the CLA :)

@josselinchevalay

Copy link
Copy Markdown
Author

ok for me that solved my issue with caps errors

@drahnr

drahnr commented Jul 23, 2019

Copy link
Copy Markdown
Contributor

Could you add print statement and show the two prints of the old and new logic. I am not quite sure what should differ between both of them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants