This repository was archived by the owner on Jan 9, 2020. It is now read-only.
Platform should be optional#27
Closed
udzura wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thank you for this fix. It looks like the field was actually removed before the 1.0 release (opencontainers/runtime-spec#850). I'm thinking it might be better to just remove it rather than make it optional. If you would like to make that change and go sign the cla I can merge your code. Otherwise I can just make the change to remove it. |
24c9e5f to
d8b4881
Compare
Author
|
I got it. Changed codes to just remove lines and force-pushed. :D |
d8b4881 to
069c9a6
Compare
Signed-off-by: Uchio KONDO <[email protected]>
Contributor
|
this was fixed in 62575a5 |
Author
|
OK, Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
struct Spec's memberplatformshould be optional,because current docker seems not to provide this in its config.json when invoke the runtime via
docker-containerd-shim.So this instruction is now broken.
(tested with Docker 17.09.0-ce on Ubuntu Zesty)